#141680: "incorrect score display"
Apakah laporan ini berkenaan?
Apakah yang berlaku? Sila pilih pilihan di bawah
Apakah yang berlaku? Sila pilih pilihan di bawah
Sila semak apakah sudah ada laporan mengenai subjek yang sama
Jika ya, sila nyatakan untuk laporan ini. Laporan dengan undian yang paling diberikan PRIORITI!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Penerangan yang terperinci
-
• Sila salin/tampal mesej masalah yang anda dapat lihat di skrin, jika ada.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Tolong jelaskan apa yang anda ingin buat, apa yang telah anda buat dan apa yang telah terjadi
• Apakah browser anda?
opera
-
• Tolong salin/lekat teks yang dipaparkan dalam bahasa inggeris dan bukannya bahasa anda. Sekiranya anda ada screenshot bug ini (amalan yang baik), anda boleh gunakan Imgur.com untuk muatnaik dan copy/paste pautan itu di sini.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Adakah teks ini tersedia dalam sistem terjemahan ? Jika ya, adakah ia diterjemahkan selama lebih daripada 24 jam?
• Apakah browser anda?
opera
-
• Tolong jelaskan cadangan anda dengan tepat dan ringkas supaya semudah mungkin untuk memahami apa yang anda maksudkan.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Apakah browser anda?
opera
-
• Apa yang dipaparkan pada skrin apabila anda disekat (Skrin kosong? Antara muka permainan? Mesej ralat?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Apakah browser anda?
opera
-
• Bahagian peraturan yang mana tidak dihormati oleh penyesuaian BGA
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Adakah kelanggaran peraturan boleh dilihat di ulangan permainan? Jikanya ya, pada langkah berapa?
• Apakah browser anda?
opera
-
• Apakan tindakan yang anda mahu lakukan?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Apa yang anda cuba lakukan untuk mencetuskan tindakan permainan ini?
-
• Apa yang berlaku apabila anda cuba melakukan ini (mesej ralat, mesej bar status permainan, ...)?
• Apakah browser anda?
opera
-
• Pada peringkat mana semasa permainan , masalah itu berlaku (apakah arahan semasa permainan tersebut)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Apa yang berlaku apabila anda cuba melakukan tindakan permainan (mesej ralat, mesej bar status permainan, ...)?
• Apakah browser anda?
opera
-
• Tolong jelaskan masalah pemaparan. Sekiranya anda ada screenshot bug ini (amalan yang baik), anda boleh gunakan Imgur.com untuk muatnaik dan copy/paste pautan itu di sini.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Apakah browser anda?
opera
-
• Tolong salin/lekat teks yang dipaparkan dalam bahasa inggeris dan bukannya bahasa anda. Sekiranya anda ada screenshot bug ini (amalan yang baik), anda boleh gunakan Imgur.com untuk muatnaik dan copy/paste pautan itu di sini.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Adakah teks ini tersedia dalam sistem terjemahan ? Jika ya, adakah ia diterjemahkan selama lebih daripada 24 jam?
• Apakah browser anda?
opera
-
• Tolong jelaskan cadangan anda dengan tepat dan ringkas supaya semudah mungkin untuk memahami apa yang anda maksudkan.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Apakah browser anda?
opera
Laporan masa lalu
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Tambah sesuatu untuk laporan ini
- ID meja yang lain / gerakkan ID
- Adakah F5 meyelesaikan masalah ity?
- Adapah masalah itu berlaku beberapa kali? Selalu? Sekali-sekala?
- Sekiranya anda ada screenshot bug ini (amalan yang baik), anda boleh gunakan Imgur.com untuk muatnaik dan copy/paste pautan itu di sini.
